Skip to content

Conversation

TheGiraffe3
Copy link
Contributor

@TheGiraffe3 TheGiraffe3 commented Oct 2, 2024

Why:

Closes: #34805

What's being changed (if available, include any code snippets, screenshots, or gifs):

Add "does not work" after each item in a list.

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Oct 2, 2024
Copy link
Contributor

github-actions bot commented Oct 2, 2024

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners.md fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10
fpt
ghec
ghes@ 3.14 3.13 3.12 3.11 3.10

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server

@subatoi
Copy link
Contributor

subatoi commented Oct 2, 2024

Thanks @TheGiraffe3 — before this is triaged I just wanted to let you know I edited your description to include the link to the issue it closes, as that feature requires the actual URL 👍

@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team repositories Content related to repositories and removed triage Do not begin working on this issue until triaged by the team labels Oct 2, 2024
@nguyenalex836
Copy link
Contributor

@TheGiraffe3 Thank you so much for opening a PR with this update! ✨

Per the issue description, can append "doesn't work" to the end of each line, rather than "does not work"? 💛

@nguyenalex836 nguyenalex836 added the more-information-needed More information is needed to complete review label Oct 2, 2024
@TheGiraffe3
Copy link
Contributor Author

Thanks @TheGiraffe3 — before this is triaged I just wanted to let you know I edited your description to include the link to the issue it closes, as that feature requires the actual URL 👍

Sorry for missing that. Thanks!

@nguyenalex836
Copy link
Contributor

@TheGiraffe3 Thanks for that update! ✨ This repo is currently in a code freeze, but we will get this merged as soon as the freeze ends on 10/7! 🍏

@nguyenalex836 nguyenalex836 added ready to merge This pull request is ready to merge and removed more-information-needed More information is needed to complete review labels Oct 2, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Oct 7, 2024
Merged via the queue into github:main with commit c25b90b Oct 7, 2024
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@TheGiraffe3 TheGiraffe3 deleted the 34805 branch October 7, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content This issue or pull request belongs to the Docs Content team ready to merge This pull request is ready to merge repositories Content related to repositories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add "...doesn't work" to the end of syntax rules for gitignore files examples in about-code-owners.md

3 participants